Prepare leader_balancer for node-local core assignment #16970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature flag will signify nodes readiness to switch to node-local assignment of partitions to cores.
Removed piece assumes that partition.replicas contains only followers and therefore contains assignment.to, but not assignment.from (under this assumption it changes assignment.to to assignment.from). But in reality partition.replicas contains all replicas, and therefore both assignment.to and assignment.from. As other code doesn't make any assumptions about presence or absence of the leader shard from the list of replicas in the index, we can simply use the original list of replicas.
After node-local partition-core assignment becomes enabled, we can no longer rely on global replica shard info from the topic table. Use shard info from the health report instead.
|
/ci-repeat |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45876#018e1ed2-1b38-4a43-881b-208de21153b0 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45897#018e1fab-80ab-460c-9044-3a9e27be3568 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45897#018e1fb1-046c-4b5e-b963-528f94e5f173 |
|
this looks good, i am wondering what will the impact of this change be for the deployments with large number of partitions |
mmaslankaprv
approved these changes
Mar 11, 2024
|
/cdt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After node-local partition-core assignment becomes enabled, we can no longer rely on global replica shard info from the topic table. Use shard info from the health report instead.
Backports Required
Release Notes