treewide: Address some warnings #16990
Conversation
`error: exception of type 'const ss::sleep_aborted &' will be caught by earlier handler [-Werror,-Wexceptions]`
```c++
class sleep_aborted : public abort_requested_exception {
```
Signed-off-by: Ben Pope <ben@redpanda.com>
`error: implicit capture of 'this' with a capture default of '=' is deprecated` Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
| @@ -129,7 +129,7 @@ seastar::future<> io_queue_workload_generator::generate_writes() { | |||
| } | |||
|
|
|||
| seastar::future<> io_queue_workload_generator::generate_reads() { | |||
| return seastar::async([=] { | |||
| return seastar::async([this] { | |||
There was a problem hiding this comment.
implicit capture of 'this' with a capture default of '=' is deprecated`
🎉
| @@ -240,7 +240,7 @@ ss::future<> connection_cache::apply_changes( | |||
| } | |||
|
|
|||
| ss::future<> connection_cache::remove_broker_client_coordinator( | |||
| model::node_id self, model::node_id dest) { | |||
There was a problem hiding this comment.
Any idea why this wasn't raising a warning on the previous compiler version? I feel like I see these get tripped all the time during development. Maybe it's always clang-tidy.
There was a problem hiding this comment.
Any idea why this wasn't raising a warning on the previous compiler version? I feel like I see these get tripped all the time during development. Maybe it's always clang-tidy.
I don't know, we have -Wall -Wextra -Werror, it's been in -Wextra since before clang-16, I can't find a change.
| auto key = api_key{i}; | ||
| auto key = api_key(i); |
There was a problem hiding this comment.
question: why prefer this change over a static cast?
There was a problem hiding this comment.
question: why prefer this change over a static cast?
Because I was being lazy, but it's a fair point.
Spotted with Clang 18
Backports Required
Release Notes