-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform-sdks: introduce integration tests #16994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
force-pushed
the
integration
branch
4 times, most recently
from
March 11, 2024 14:38
ce65dcb
to
c4223ee
Compare
pgellert
previously approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Force push: Make test skipping explicit |
Add an identity transform integration test for all the different SDKs we will support. This is a generic runner that will just take Wasm files as input. We will use this to add tests for each of the SDKs to ensure they work with the broker. These tests are less expensive than running each one within the broker's test suite, so we have this seperate smaller test suite that ensures the SDKs are doing the right thing, since the broker's tests are more about validating the broker is doing the right thing. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Force push: fix build warning |
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Force push: lower retention for integration test artifact |
pgellert
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only our golang SDK is tested as part of the broker tests. We want to test all of our SDKs. Since the broker's test suite is very heavy we will create a standalone test suite for this using our nightly docker image. Currently there is only a single unit test for the identity transform, but over time we'll add tests for schema registry and multiple output topics here too (as new languages come up).
Backports Required
Release Notes