treewide: Reduce header dependencies #17002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenPope
changed the title
|
Wow thanks for slogging through this 😍 |
BenPope
force-pushed
the
reduce_header_dependencies
branch
from
35a5ac2
to
c6bb5ce
Compare
BenPope
force-pushed
the
reduce_header_dependencies
branch
from
c6bb5ce
to
8016983
Compare
BenPope
changed the title
BenPope
force-pushed
the
reduce_header_dependencies
branch
from
8016983
to
53478d3
Compare
|
thank you for that Ben 🙇🏼♂️ |
Yes of course, this is the best commit! So cluster::partition includes a fair bit of code. By allowing the type to be incomplete, it allows us to not have to include the file until the
Now, users of |
rockwotj
previously approved these changes
Mar 12, 2024
|
@BenPope this is super cool. prolly worth a training chat on tuesday w/ the team |
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
reduce_header_dependencies
branch
from
53478d3
to
cf3f1d8
Compare
|
Changes in force push
|
rockwotj
approved these changes
Mar 16, 2024
dotnwat
reviewed
Mar 19, 2024
Comment on lines
+23
to
+46
| enum class consistency_level { quorum_ack, leader_ack, no_ack }; | ||
|
|
||
| struct replicate_options { | ||
| explicit replicate_options(consistency_level l) | ||
| : consistency(l) | ||
| , timeout(std::nullopt) {} | ||
|
|
||
| replicate_options(consistency_level l, std::chrono::milliseconds timeout) | ||
| : consistency(l) | ||
| , timeout(timeout) {} | ||
|
|
||
| consistency_level consistency; | ||
| std::optional<std::chrono::milliseconds> timeout; | ||
| }; | ||
|
|
||
| struct replicate_result { | ||
| /// used by the kafka API to produce a kafka reply to produce request. | ||
| /// see produce_request.cc | ||
| model::offset last_offset; | ||
| }; | ||
|
|
||
| struct replicate_stages { | ||
| replicate_stages(ss::future<>, ss::future<result<replicate_result>>); | ||
| explicit replicate_stages(raft::errc); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This focuses primarily on header files. The goal was to reduce the header dependencies between
raft&clusterand other libraries such askafka.Another effort in another PR can focus on removing unused includes from .cc files.
Backports Required
Release Notes