Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check cloud type and do not run if FMC #17010

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

rpdevmp
Copy link
Contributor

@rpdevmp rpdevmp commented Mar 12, 2024

This is a HTT cloud type check for:
https://github.com/redpanda-data/core-internal/issues/990

This test was designed for BYOC only, and code already has a message:

Using it against FMC clouds will cause it to fail as
there is no access to S3 account that is used inside
cloudv2 API to create/update buckets and its
properties/policies

This improvement would check if test is being executed on FMC and show a warning in logs as well is would not be executed

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Improvements

  • See above

@rpdevmp rpdevmp requested review from travisdowns and removed request for andrewhsu, ivotron and savex March 14, 2024 23:15
@rpdevmp
Copy link
Contributor Author

rpdevmp commented Mar 14, 2024

This one is checking for environment type.
As discussed, we will have another ticket where we add a notation and would be able to skip tests based on environment. Where test results would actually say skipped.
Tracked here and here

@rpdevmp rpdevmp requested a review from savex March 14, 2024 23:23
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I guess that effort required to properly skip this test all the way is too high

@rpdevmp
Copy link
Contributor Author

rpdevmp commented Mar 15, 2024

That was an initial change to just to add a message. I have another one that would be skipping the test:
https://github.com/redpanda-data/core-internal/issues/1169 (still need to test that one before creating a PR)

@rpdevmp rpdevmp merged commit 82b6f2e into dev Mar 15, 2024
16 checks passed
@rpdevmp rpdevmp deleted the rpdevmp/HTT-fmc-check-990 branch March 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants