[v23.3.x] cluster: Avoid oversize allocs for topic creation and configuration #17012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A future PR will use `chunked_vector` in addition to `std::vector` Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit f524df7)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 12daecc)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 99247c5)
BenPope
added
kind/backport
`topic_configuration` is 392 bytes `custom_assignable_topic_configuration` is 416 bytes Switch vectors of them to `chunked_vector` Fixes redpanda-data#16758 Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit d58c9fa) Conflicts: src/v/compat/cluster_generator.h (didn't provide the size)
`topic_properties_update` is 456 bytes. Switch it to from `std::vector` to `chunked_vector`. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 9191f39)
BenPope
force-pushed
the
backport-pr-16982-v23.3.x
branch
from
6dc4b63
to
dab1205
Compare
StephanDollberg
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16982
Fixes: #16993