Fix a segfault when recovery mode is partially enabled #17013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these requests resulted in segfaults.
Mostly this test is a smoke test for mixed recovery mode - nodes should successfully restart and not segfault.
mmaslankaprv
approved these changes
Mar 12, 2024
emaxerrno
reviewed
Mar 12, 2024
| @@ -42,13 +42,21 @@ class offsets_recovery_rpc_service : public offsets_recovery_service { | |||
|
|
|||
| ss::future<offsets_upload_reply> offsets_upload( | |||
| offsets_upload_request req, rpc::streaming_context& ctx) override { | |||
| if (!_offsets_upload_router.local_is_initialized()) { | |||
andrwng
approved these changes
Mar 12, 2024
|
/backport v23.3.x |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a mixed-mode clusters RPC requests for uploading consumer offsets to cloud storage could be issued from a node in normal mode to a node in recovery mode. Previously this resulted in a segfault.
Backports Required
Release Notes
Bug Fixes