Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/cmake_test: remove accidental env override #17027

Merged
merged 2 commits into from
Mar 22, 2024
Merged

tools/cmake_test: remove accidental env override #17027

merged 2 commits into from
Mar 22, 2024

Conversation

nvartolomei
Copy link
Contributor

This nuked the above set environment variables. Noticed this because unit tests were succeeded with UBSAN warnings which meant that halt_on_error=1:abort_on_error=1 didn't take effect.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@nvartolomei
Copy link
Contributor Author

/dt

@nvartolomei
Copy link
Contributor Author

/ci-repeat 1
tests/rptest/tests/cluster_config_test.py::ClusterConfigUnknownTest

@nvartolomei
Copy link
Contributor Author

/dt
ci-repeat 1
tests/rptest/tests/cluster_config_test.py::ClusterConfigUnknownTest

rockwotj
rockwotj previously approved these changes Mar 13, 2024
View reviewed changes
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 13, 2024 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46105#018e3799-a497-4b64-9106-d5c0667ec996

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46484#018e5a8e-13a7-4ed8-9e5e-6b575d192630

@nvartolomei
Copy link
Contributor Author

Requires #17026

dotnwat
dotnwat approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@nvartolomei nvartolomei mentioned this pull request Mar 14, 2024
Merged
6 tasks
@nvartolomei
tools/cmake_test: remove accidental env override
4068bb5 
This nuked the above set environment variables. Noticed this because
unit tests were succeeded with UBSAN warnings which meant that
`halt_on_error=1:abort_on_error=1` didn't take effect.
@nvartolomei
cloud_storage_clients: fix a typo
40e1797
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 20, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/46484#018e5a9f-c206-47f8-8256-d18f20ecf000:

"rptest.tests.offset_for_leader_epoch_archival_test.OffsetForLeaderEpochArchivalTest.test_querying_remote_partitions.remote_reads=.False.True"

new failures in https://buildkite.com/redpanda/redpanda/builds/46491#018e5ba2-0ad4-476e-b077-e69bceb7fcad:

"rptest.tests.control_character_flag_test.ControlCharacterPermittedAfterUpgrade.test_upgrade_from_pre_v23_2.initial_version=.22.2.9"

new failures in https://buildkite.com/redpanda/redpanda/builds/46491#018e5bb4-b8be-475c-b87d-963e63fb695b:

"rptest.tests.partition_movement_test.PartitionMovementTest.test_deletion_stops_move.num_to_upgrade=2"

@nvartolomei
Copy link
Contributor Author

/dt
tests/rptest/tests/offset_for_leader_epoch_archival_test.py::OffsetForLeaderEpochArchivalTest. test_querying_remote_partitions

@nvartolomei nvartolomei merged commit 167831b into redpanda-data:dev Mar 22, 2024
17 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

This was referenced Mar 22, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@rockwotj rockwotj rockwotj approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nvartolomei @vbotbuildovich @dotnwat @rockwotj