rptest: fix _lifecycle_test naming #17085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ducktape uses method naming to decide what is a test and our ManyTopicsTest had a _lifecycle_test method which is a helper called by tests and not a standalone test itself, but DT will call it as a standalone test causing a CI failure. Rename it to _lifecycle_test_impl to avoid this. Fixes redpanda-data#17040.
dotnwat
approved these changes
Mar 14, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46151#018e3ab9-caa8-48c8-973d-24992358572c ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46151#018e3ab9-caa4-41bf-90b1-7ba9e3c87165 |
|
Force merged: all CI passed but stuck in "waiting for status" state, see: https://redpandadata.slack.com/archives/C06MCRY75U7/p1710389607342359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ducktape uses method naming to decide what is a test and our ManyTopicsTest had a _lifecycle_test method which is a helper called by tests and not a standalone test itself, but DT will call it as a standalone test causing a CI failure.
Rename it to _lifecycle_test_impl to avoid this.
Fixes #17040.
Backports Required
Release Notes