container: add interval_set #17087
container: add interval_set #17087
Conversation
There was a problem hiding this comment.
Will review fully later, but initial thoughts:
- Should this go src/v/container if it isn't used in
io::and if it's going to be used by the new local-storage layer, then I think that is going to be separate from theio::facilities. - Since you are dealing with coalescing of interval overlaps, I wonder if you would want to use boost/icl? I think that the aggregation of overlaps there has some unique properties like favoring new/old inserts that overlap. But anyway, overall this looks good.
Ah yea it wouldn't be a big lift to use that. Will consider for sure -- the only reason I can think of to have our own impl would be to control the underlying container, which isn't the biggest win. |
Having our own implementation is also nice because we don't have to learn another boost library. |
This adds an interval_set class, similar to interval_map with a couple key differences: - it is a set type, and only tracks the intervals rather than an additional value type - it supports inserting overlapping intervals by coalescing them This will be a used in an upcoming change to track regions within a file to skip over, which will be key to a append-only log implementation that truncates by appending metadata to the log. The structure and some of the implementation of the interval_set is copied directly from interval_map, though the insert() method is significantly different, given the above behavioral differences.
Yeah that's a good point. Done |
This adds an interval_set class, similar to interval_map with a couple key differences:
This will be a used in an upcoming change to track regions within a file to skip over, which will be key to a append-only log implementation that truncates by appending metadata to the log.
The structure and some of the implementation of the interval_set is copied directly from interval_map, though the insert() method is significantly different, given the above behavioral differences.
Backports Required
Release Notes