[v23.3.x] c/topic_table: replaced partition metadata map with chunked_vector #17093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a nice way to simulate `zip` similar to the python function for two different containers. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Contiguous range map is an associative sorted container backed by chunked_vector designed to efficiently store objects indexed with contiguous and limited range of integers. The container provides a wrapper around basic chunked vector that reassembles API of a standard map. The wrapper allows random inserts of elements to the map event tho this is not supported by standard vector. Underlying container is resized every time its size is not sufficient to account for emplaced key. The contiguous_range_map tolerates gap in the range of keys however number and size of gaps is proportional to performance penalty hit when incrementing or decrementing iterators. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 0a67885)
Signed-off-by: Michal Maslanka <michal@redpanda.com>
To avoid large allocations and still provide good performance, replaced the `absl::node_hash_map` containing per partition metadata with `contiguous_range_map` which is backed by chunked vector. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 16fb270)
mmaslankaprv
force-pushed
the
vbotbuildovich/backport-16919-v23.3.x-938
branch
from
530fe69
to
590e3f5
Compare
piyushredpanda
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16919