rpk profile: a few more fixes #17117
Merged
+71
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deletes some old logic that avoided prompting if only one cluster existed * Made some testing branch _much_ more foolproof. Turns out we use an empty cloud URL always, which then defaults to prod inside the cloud API package.
If we're going to delete an auth, we WILL delete the profile on the next run. Do it all in one run.
r-vasquez
approved these changes
Mar 15, 2024
|
Bypassing tests to get this merged ASAP for the backport -- we don't expect tests to fail based on repeated local testing, and current tests being unrelated to these changes. |
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes