Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-20: Use a venv to install and use ducktape #17119

Merged
merged 1 commit into from
Mar 18, 2024
Merged

CORE-20: Use a venv to install and use ducktape #17119

merged 1 commit into from
Mar 18, 2024

Conversation

michael-redpanda
Copy link
Contributor

  • Creates a venv in /opt/.ducktape-venv that is used for ducktape installation
  • Adds /opt/.ducktape-venv/bin to global path so all shells will utilize the venv for python operations
  • Conditionally install python3.10 from deadsnakes ppa if installation script detects that Ubuntu OS in use is 20.04

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@michael-redpanda
dt: Use a venv to install and use ducktape
8a807d0 
- Creates a venv in /opt/.ducktape-venv that is used for ducktape
  installation
- Adds /opt/.ducktape-venv/bin to global path so all shells will utilize
  the venv for python operations
- Conditionally install python3.10 from deadsnakes ppa if installation
  script detects that Ubuntu OS in use is 20.04

Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda michael-redpanda self-assigned this Mar 15, 2024
@michael-redpanda
Copy link
Contributor Author

/dt

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 15, 2024 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46280#018e42d8-3add-4c0c-ae8e-f5e0b963167d

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46280#018e42d8-3ae0-4c20-86ed-8f2ae2dd41a3

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46280#018e42e9-7207-4e71-9a92-0720bb099cc3

@michael-redpanda michael-redpanda marked this pull request as ready for review March 15, 2024 17:49
@michael-redpanda michael-redpanda requested a review from a team as a code owner March 15, 2024 17:49
@michael-redpanda michael-redpanda requested review from gousteris, travisdowns and andrewhsu and removed request for a team March 15, 2024 17:49
@michael-redpanda
Copy link
Contributor Author

/cdt

@andrewhsu
Copy link
Member

/cdt
rp_version=build

@michael-redpanda
Copy link
Contributor Author

/cdt
rp_version=build
ducktape_deps_git_version=CORE-20-make-ubuntu-2004-work
tests/rptest/tests/random_node_operations_test.py

andrewhsu
andrewhsu approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@michael-redpanda michael-redpanda merged commit af731f5 into redpanda-data:dev Mar 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

@gousteris gousteris Awaiting requested review from gousteris gousteris is a code owner automatically assigned from redpanda-data/devprod

@travisdowns travisdowns Awaiting requested review from travisdowns

Assignees

@michael-redpanda michael-redpanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michael-redpanda @vbotbuildovich @andrewhsu