rpk profile double pointer fixes #17170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we made an auth current, we reordered the underlying auth slice which is _not_ pointer based. Any changes to the pointer fields _after_ reodering were changes to an old slice that would no longer be saved. Now, we MakeAuthCurrent with two pointer indirects -- The underlying pointer to the slice element is used for the invariant check, did we find this auth. We now update the pointer-to-the-pointer so that if we update any fields _after_ MakeAuthCurrent, they're mirrored into the new slice.
For the same reasons as the prior commit. Only `rpk profile create` actually modify the profile fields after the move, and only in `rpk profile create --from-cloud`.
gene-redpanda
previously approved these changes
Mar 18, 2024
We were updating the virtual yaml, but not the actual yaml. We want to update the actual so that when a save happens, the version is bumped.
jan-g
approved these changes
Mar 18, 2024
|
Bypassing test suite due to extensive local testing, and existing tests don't cover changes here (which is definitely something to work on as a follow up) |
|
/backport v23.3.x |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46381#018e52f7-1322-4fad-a851-6ecda6e0b30b ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46381#018e52f7-131f-48a8-8170-b4ec06bc945b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes