Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to skip the test based on cloud_type GH:1169 Jira:PESDLC-971 #17183

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

rpdevmp
Copy link
Contributor

@rpdevmp rpdevmp commented Mar 19, 2024

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Improvements

  • Ability to skip tests based on provider FMC (dedicated) or BYOC. We also have a check at runtime to skip certian tests if on dedicated, but this notation allows to specify if test should be skipped. We would have similar decorators/notations for aws/gcp/azure in case some tests would be only related to specific cloud

@rpdevmp rpdevmp requested a review from savex March 19, 2024 16:56
@vbotbuildovich
Copy link
Collaborator

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/46442#018e57f1-04a0-4d81-b022-cc6adacdfe41:

"rptest.tests.read_replica_e2e_test.TestReadReplicaService.test_identical_lwms_after_delete_records.partition_count=5.cloud_storage_type=CloudStorageType.S3"

Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green build

@piyushredpanda
Copy link
Contributor

Known failures: #14139 and #17247

@piyushredpanda piyushredpanda merged commit ede8a5b into dev Apr 1, 2024
13 of 17 checks passed
@piyushredpanda piyushredpanda deleted the rpdevmp/PESDLC-971 branch April 1, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants