Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-2177: rptest: e2e write caching tests with failure injection #17236

Merged
merged 5 commits into from
Apr 13, 2024

Conversation

nvartolomei
Copy link
Contributor

@nvartolomei nvartolomei commented Mar 21, 2024

Depends on #17674
Closes https://github.com/redpanda-data/core-internal/issues/1247

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@nvartolomei nvartolomei requested a review from a team as a code owner March 21, 2024 09:54
@nvartolomei nvartolomei requested review from rpdevmp and removed request for a team March 21, 2024 09:54
@nvartolomei nvartolomei changed the title rptest: write caching tests DNM rptest: write caching tests Mar 21, 2024
@nvartolomei nvartolomei force-pushed the nv/wc-test branch 3 times, most recently from 0b63ec7 to 761b4a3 Compare March 21, 2024 14:26
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Mar 21, 2024
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Mar 21, 2024
@nvartolomei nvartolomei force-pushed the nv/wc-test branch 2 times, most recently from 9bb3462 to 38eaac1 Compare March 21, 2024 17:06
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Mar 21, 2024
@nvartolomei nvartolomei force-pushed the nv/wc-test branch 2 times, most recently from 8ca9a26 to 6733042 Compare March 27, 2024 14:16
@nvartolomei nvartolomei marked this pull request as draft April 8, 2024 10:03
@nvartolomei nvartolomei changed the title DNM rptest: write caching tests rptest: end-2-end write caching tests Apr 8, 2024
@nvartolomei nvartolomei changed the title rptest: end-2-end write caching tests rptest: end-2-end write caching tests with failure injection Apr 8, 2024
@nvartolomei nvartolomei changed the title rptest: end-2-end write caching tests with failure injection rptest: e2e write caching tests with failure injection Apr 8, 2024
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Apr 8, 2024
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Apr 8, 2024
@nvartolomei nvartolomei marked this pull request as ready for review April 10, 2024 17:07
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 10, 2024

Copy link
Contributor

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor comments.

tests/rptest/services/redpanda.py Outdated Show resolved Hide resolved
tests/rptest/tests/write_caching_fi_e2e_test.py Outdated Show resolved Hide resolved
tests/rptest/tests/write_caching_fi_e2e_test.py Outdated Show resolved Hide resolved
@nvartolomei
Copy link
Contributor Author

Force pushed to address @bharathv feedback and rebased on dev.

Prevents bugs caused by the same node appearing multiple times in the
list.

Happens for example when when we kill signal a node and then we start
it. Although we could check manually the presence in the list, it is
more bug prone approach.

There are cases when we want to operate on each started node
concurrently and if we have a node registered multiple times then we run
into very hard to debug race conditions. Example is
RedpandaService.all_up method.
@nvartolomei
Copy link
Contributor Author

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/47671#018ecddf-cd1e-4882-b2fd-37c9be9d4ea9:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves.cleanup_policy=compact.delete"

@nvartolomei
Copy link
Contributor Author

nvartolomei commented Apr 11, 2024

@dotnwat dotnwat changed the title rptest: e2e write caching tests with failure injection CORE-2177: rptest: e2e write caching tests with failure injection Apr 12, 2024
@dotnwat dotnwat merged commit 9fe664f into redpanda-data:dev Apr 13, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants