Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_table: remove dependency on cluster/types.h #17242

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Mar 21, 2024

Feature table is included all over the tree, yet it included
cluster/types.h which has a large number of other dependencies. Feature
table only needs the cluster_version definition. In affect feature table
was being used around the tree as an implicit alias for cluster/types.h.

  In file included from src/v/storage/segment_reader.cc:16:
  In file included from src/v/storage/segment_utils.h:20:
  In file included from src/v/storage/readers_cache.h:20:
  In file included from src/v/storage/log_reader.h:20:
  In file included from src/v/storage/segment.h:20:
  In file included from src/v/storage/segment_index.h:13:
  In file included from src/v/features/feature_table.h:14:
  In file included from src/v/cluster/types.h:14:
  In file included from src/v/cluster/cloud_metadata/cluster_manifest.h:13:
  In file included from src/v/cloud_storage/base_manifest.h:14:
  In file included from src/v/cloud_storage/types.h:14:
  In file included from src/v/cloud_storage_clients/configuration.h:14:
  src/redpanda-storage-v2/src/v/cloud_storage_clients/client_probe.h:17:10: fatal error: 'http/probe.h' file not found
  #include "http/probe.h"

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Feature table is included all over the tree, yet it included
cluster/types.h which has a large number of other dependencies. Feature
table only needs the cluster_version definition. In affect feature table
was being used around the tree as an implicit alias for cluster/types.h.

  In file included from src/v/storage/segment_reader.cc:16:
  In file included from src/v/storage/segment_utils.h:20:
  In file included from src/v/storage/readers_cache.h:20:
  In file included from src/v/storage/log_reader.h:20:
  In file included from src/v/storage/segment.h:20:
  In file included from src/v/storage/segment_index.h:13:
  In file included from src/v/features/feature_table.h:14:
  In file included from src/v/cluster/types.h:14:
  In file included from src/v/cluster/cloud_metadata/cluster_manifest.h:13:
  In file included from src/v/cloud_storage/base_manifest.h:14:
  In file included from src/v/cloud_storage/types.h:14:
  In file included from src/v/cloud_storage_clients/configuration.h:14:
  src/redpanda-storage-v2/src/v/cloud_storage_clients/client_probe.h:17:10: fatal error: 'http/probe.h' file not found
  #include "http/probe.h"

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dotnwat dotnwat merged commit e26990e into redpanda-data:dev Mar 21, 2024
12 of 17 checks passed
@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/46572#018e6203-4bf9-4459-bab5-45360535d504:

"rptest.tests.read_replica_e2e_test.TestReadReplicaService.test_identical_lwms_after_delete_records.partition_count=5.cloud_storage_type=CloudStorageType.S3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants