transform-sdk/cpp: add string_view conversion from bytes_view #17249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will probably be a common operation, so make it easier for users. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
If you want to abort use the abort function. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
force-pushed
the
string_view_conversion
branch
from
041e69c
to
a5f9f98
Compare
oleiman
approved these changes
Mar 21, 2024
Comment on lines
+275
to
+277
| .transform([](bytes_view buf) { | ||
| return std::string_view{buf}; | ||
| }) |
There was a problem hiding this comment.
don't know how I missed this in the first round of CR but 🔥 🔥 🔥
There was a problem hiding this comment.
optional<T>::transform I mean. so good
| @@ -424,6 +420,10 @@ bytes::value_type bytes_view::operator[](size_t n) const { return _start[n]; } | |||
| bool bytes_view::operator==(const bytes_view& other) const { | |||
| return std::ranges::equal(*this, other); | |||
| } | |||
| bytes_view::operator std::string_view() const { | |||
There was a problem hiding this comment.
nit: looks like you're using this explicit...should it be declared so?
There was a problem hiding this comment.
No explicit doesn't take place in overlod resolution and it's only allowed at declaration
There was a problem hiding this comment.
Oh, it is declared explicit. My mistake. Thought I was looking at the declaration right here 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small QoL improvement for the C++ SDK.
Backports Required
Release Notes