Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.3.x] rpk: enable using public API in rpk transform #17252

Merged
merged 12 commits into from
Mar 23, 2024

Conversation

r-vasquez
Copy link
Contributor

Backport of #17023

This PR includes a series of commits that enable using the cloud Public API in our rpk transform command.

  • bda4c08 removes the shell script used to autogenerate the files now that everything is generated. We will be moving this to vtools.
  • 2d3f862 replaces our grpc client for a connect client, which lets us use an HTTP client, which makes more sense since rpk transform deploy requires an HTTP client. Also provides a better error handling that matches rpk style already.
  • 0b3d9e5 adds the cluster information to our rpk profile. This requires an rpk version bump. This is the main enabler for the rest of the logic in this PR.
  • Last 3 commits introduce the logic to run rpk transform with the new clients

Fixes #17235

Backports Required

This feature will be backported manually to v23.2.x

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Features

  • rpk: support running rpk transform against Redpanda cloud clusters.

This is no longer needed, moved to vtools

(cherry picked from commit 8618322)
This commit changes the grpc client for
an equivalent connectGRPC client.

It also adds a new logger interceptor
to log the host and procedure of every
request.

(cherry picked from commit cf262d6)
And hide namespace command. This will be
soon deprecated.

(cherry picked from commit 9eaf643)
This commit introduces a new clientSet
focused to the dataplane endpoints.

It includes an extension of the
connectrpc client because we don't
support DeployTransforms in gRPC.

(cherry picked from commit 61ee37d)
And profile creation.

This will save more information in the rpk.yaml
on login/profile creation.

This include a rpk.yaml version bump since old
rpk's won't be able to parse since it's a new
struct definition.

(cherry picked from commit ca7046f)
Now `rpk transform list` will select the
appropriate client based on the profile content.

(cherry picked from commit f12a3ab)
These are autogenerated.

(cherry picked from commit c21cdec)
@r-vasquez r-vasquez requested review from twmb, gene-redpanda and a team as code owners March 22, 2024 00:32
@r-vasquez r-vasquez requested review from savex and removed request for a team March 22, 2024 00:32
@r-vasquez r-vasquez changed the title Backport pr 17023 v23.3 [v23.3.x] rpk: enable using public API in rpk transform Mar 22, 2024
@rockwotj rockwotj added this to the v23.3.x-next milestone Mar 22, 2024
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@r-vasquez r-vasquez merged commit d7a2390 into redpanda-data:v23.3.x Mar 23, 2024
25 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.3.x-next, v23.3.10 Mar 23, 2024
@r-vasquez r-vasquez deleted the backport-pr-17023-v23.3 branch April 12, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants