-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v23.3.x] rpk: enable using public API in rpk transform #17252
Merged
r-vasquez
merged 12 commits into
redpanda-data:v23.3.x
from
r-vasquez:backport-pr-17023-v23.3
Mar 23, 2024
Merged
[v23.3.x] rpk: enable using public API in rpk transform #17252
r-vasquez
merged 12 commits into
redpanda-data:v23.3.x
from
r-vasquez:backport-pr-17023-v23.3
Mar 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed, moved to vtools (cherry picked from commit 8618322)
This commit changes the grpc client for an equivalent connectGRPC client. It also adds a new logger interceptor to log the host and procedure of every request. (cherry picked from commit cf262d6)
(cherry picked from commit b9460c6)
And hide namespace command. This will be soon deprecated. (cherry picked from commit 9eaf643)
This commit introduces a new clientSet focused to the dataplane endpoints. It includes an extension of the connectrpc client because we don't support DeployTransforms in gRPC. (cherry picked from commit 61ee37d)
And profile creation. This will save more information in the rpk.yaml on login/profile creation. This include a rpk.yaml version bump since old rpk's won't be able to parse since it's a new struct definition. (cherry picked from commit ca7046f)
(cherry picked from commit b94a068)
Now `rpk transform list` will select the appropriate client based on the profile content. (cherry picked from commit f12a3ab)
(cherry picked from commit d60737e)
(cherry picked from commit 5ba20b6)
These are autogenerated. (cherry picked from commit c21cdec)
(cherry picked from commit 6c1c11c)
r-vasquez
changed the title
Backport pr 17023 v23.3
[v23.3.x] rpk: enable using public API in rpk transform
Mar 22, 2024
gene-redpanda
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17023
This PR includes a series of commits that enable using the cloud Public API in our
rpk transform
command.rpk transform deploy
requires an HTTP client. Also provides a better error handling that matches rpk style already.rpk profile
. This requires an rpk version bump. This is the main enabler for the rest of the logic in this PR.rpk transform
with the new clientsFixes #17235
Backports Required
This feature will be backported manually to v23.2.x
Release Notes
Features
rpk transform
against Redpanda cloud clusters.