Remove global dependencies from test_utils/random #17352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
requested review from
rockwotj,
bharathv,
WillemKauf,
andrwng and
michael-redpanda
Test utils is a global library, but had lots of bits from modules (e.g. security, model, etc...). This resulted in a lot of implicit dependencies. This commit splits it and includes the specializations in each module. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
force-pushed
the
test-utils-headers
branch
from
636eb79
to
623cdc5
Compare
|
Force-push: missed one in release builds. |
dotnwat
changed the title
andrwng
approved these changes
Mar 23, 2024
| @@ -11,8 +11,6 @@ | |||
|
|
|||
| #include "base/likely.h" | |||
| #include "base/vlog.h" | |||
| #include "cluster/cluster_utils.h" | |||
| #include "cluster/topic_table.h" | |||
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6cf8-4f0a-4251-9690-223169f04e6b ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6d0a-6f8f-4198-a72d-f2ac09cee060 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6d0a-6f8a-4097-b1ea-6c25bec4ee32 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6d0a-6f8c-4f94-a9c8-a7680eb4ec16 |
|
CI failure #14425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split up test_utils header for greater good
Backports Required
Release Notes