storage: coalesce and rename record batch disk serialization methods #17357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, there will be more kinds of headers stored on disk. To clarify, this changes the name to batch_header_to_disk_iobuf.
The utilities are used in the appender, but are used broadly for generic serialization from disk. This renames the corresponding files to record_batch_utils.*.
Puts it together with the corresponding serialization utils.
Similar to the corresponding serialization method, adds a name that clarifies the kind of header and the kind of serialization.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46675#018e6e31-af88-437a-a688-237b7ebe4ac3 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46675#018e6e5a-f8bd-4204-9bf0-2235f84048d3 |
dotnwat
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames some on-disk serialization methods for record batch headers to clarify that they're used for batch headers, and that the serialization is meant for on-disk serialization.
Also moves/renames from segment_appender_utils to a new record_batch_utils, since they're used beyond the scope of the segment appender.
Backports Required
Release Notes