Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform/processor test: prevent batching flakes #17376

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Mar 25, 2024

We now batch variably in the processor, so if we schedule tasks just
right we can end up with a case where there is an unexpected size
according to our assertions, but that is still valid.

Fixes: #17367

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

We now batch variably in the processor, so if we schedule tasks just
right we can end up with a case where there is an unexpected size
according to our assertions, but that is still valid.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@github-actions github-actions bot added area/redpanda area/wasm WASM Data Transforms labels Mar 25, 2024
@rockwotj rockwotj requested a review from oleiman March 25, 2024 20:06
@rockwotj rockwotj self-assigned this Mar 25, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbotbuildovich
Copy link
Collaborator

@rockwotj rockwotj merged commit 28a0654 into redpanda-data:dev Mar 25, 2024
19 checks passed
@rockwotj rockwotj deleted the processor-test-fixes branch March 26, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda area/wasm WASM Data Transforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test Failure (value mismatch) in MultipleOutputsProcessorTest.TracksProcessPerOutput
4 participants