-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): Handle EDITOR with options #17387
Conversation
|
When doing `rpk cluster config edit` leverage the editor with options. fixes: 17386
40c5402
to
5fcb6a3
Compare
@rockwotj - I have squashed all my commits into one and that includes all our discussions. Please feel free to merge it. |
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47117#018e9056-fbb8-4be7-ab80-31b8124a02a0 |
Thank you @kameshsampath for your contribution! |
When doing
rpk cluster config edit
leverage the editor options. For example if theEDITOR
is set tocode -w
, then therpk cluster config edit
should run a editor command likecode -w <cluster config tempfile
.The commit splits the
EDITOR
environment variable with options and appends the tempfile as the last argument.Fixes: 17386
Backports Required
Bug Fixes
Leverage the editor(
$EDITOR
) options using comandrpk cluster config edit
.Improvements
The developer can now set editor to something like EDITOR='code -w
and run the
rpk cluster config edit` to be able to make the editor wait for the editing to be saved/discarded.