Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Handle EDITOR with options #17387

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

kameshsampath
Copy link
Contributor

When doing rpk cluster config edit leverage the editor options. For example if the EDITOR is set to code -w, then the rpk cluster config edit should run a editor command like code -w <cluster config tempfile.

The commit splits the EDITOR environment variable with options and appends the tempfile as the last argument.

Fixes: 17386

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Bug Fixes

Leverage the editor($EDITOR) options using comandrpk cluster config edit.

Improvements

The developer can now set editor to something like EDITOR='code -wand run therpk cluster config edit` to be able to make the editor wait for the editing to be saved/discarded.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@twmb twmb added this to the v23.3.10 milestone Mar 26, 2024
@piyushredpanda piyushredpanda modified the milestones: v23.3.10, v23.3.x-next Mar 28, 2024
When doing `rpk cluster config edit` leverage the editor with options.

fixes: 17386
@kameshsampath
Copy link
Contributor Author

@rockwotj - I have squashed all my commits into one and that includes all our discussions. Please feel free to merge it.

@vbotbuildovich
Copy link
Collaborator

@rockwotj rockwotj merged commit 2a224ec into redpanda-data:dev Mar 30, 2024
22 checks passed
@rockwotj
Copy link
Contributor

Thank you @kameshsampath for your contribution!

@kameshsampath kameshsampath deleted the issue-17386 branch March 31, 2024 02:49
@piyushredpanda piyushredpanda modified the milestones: v23.3.x-next, v23.3.11 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants