Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-14 disable tests that fail in fips #17391

Merged
merged 3 commits into from
Mar 28, 2024
Merged

CORE-14 disable tests that fail in fips #17391

merged 3 commits into from
Mar 28, 2024

Conversation

michael-redpanda
Copy link
Contributor

Add support for disabling tests in FIPS mode

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • None

@michael-redpanda
Copy link
Contributor Author

/cdt
fips
rp_git_version=CORE-14-disable-tests-that-fail-in-fips
ducktape_deps_git_version=CORE-14-disable-tests-that-fail-in-fips

@michael-redpanda michael-redpanda changed the title Core 14 disable tests that fail in fips CORE-14 disable tests that fail in fips Mar 26, 2024
@michael-redpanda
Copy link
Contributor Author

/cdt
fips
rp_git_version=CORE-14-disable-tests-that-fail-in-fips
ducktape_deps_git_version=CORE-14-disable-tests-that-fail-in-fips
rp_version=build

1 similar comment
@michael-redpanda
Copy link
Contributor Author

/cdt
fips
rp_git_version=CORE-14-disable-tests-that-fail-in-fips
ducktape_deps_git_version=CORE-14-disable-tests-that-fail-in-fips
rp_version=build

@michael-redpanda michael-redpanda self-assigned this Mar 26, 2024
@michael-redpanda
Copy link
Contributor Author

/cdt
fips
rp_git_version=CORE-14-disable-tests-that-fail-in-fips
ducktape_deps_git_version=CORE-14-disable-tests-that-fail-in-fips
rp_version=build

@michael-redpanda michael-redpanda force-pushed the CORE-14-disable-tests-that-fail-in-fips branch from e93607c to a204ecb Compare March 27, 2024 00:28
@michael-redpanda
Copy link
Contributor Author

/cdt
fips
rp_git_version=CORE-14-disable-tests-that-fail-in-fips
ducktape_deps_git_version=CORE-14-disable-tests-that-fail-in-fips
rp_version=build

1 similar comment
@michael-redpanda
Copy link
Contributor Author

/cdt
fips
rp_git_version=CORE-14-disable-tests-that-fail-in-fips
ducktape_deps_git_version=CORE-14-disable-tests-that-fail-in-fips
rp_version=build

@michael-redpanda michael-redpanda force-pushed the CORE-14-disable-tests-that-fail-in-fips branch from a204ecb to 2776207 Compare March 27, 2024 17:32
@michael-redpanda michael-redpanda marked this pull request as ready for review March 27, 2024 17:36
@michael-redpanda
Copy link
Contributor Author

flink may be the last test that doesn't work in FIPS environment, but will address that later as it's only two tests.

@michael-redpanda
Copy link
Contributor Author

Blocked on redpanda-data/ducktape#33. Once merged need to update sha

@michael-redpanda
Copy link
Contributor Author

Example output: https://ci-artifacts.dev.vectorized.cloud/redpanda/46868/018e7f27-7210-40f4-b3f9-184ef1bf35cd/vbuild/ducktape/results/2024-03-27--001/report.html

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 27, 2024 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46907#018e812c-2a1c-4d8c-8a05-24695e20cd98

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46907#018e813d-e828-4cfe-95a3-fef8b6ac70ba

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46907#018e813d-e825-4beb-8b8f-94add02d06e8

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46907#018e813d-e822-45b8-9e5b-9a015b905a6a

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46926#018e81c8-f7b4-45fc-abe0-3209ba1f0b3f

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46925#018e81ea-7b7a-4127-b028-f9b106278d59

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46947#018e82b7-1b8e-4557-be7b-c4e4163d4727

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46947#018e82ba-b6df-4561-87ff-5e3de12705fe

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46947#018e82ba-b6dd-404c-984a-77be6e38c6e7

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46978#018e8496-d695-4335-9688-74e71ca154a9

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46978#018e8496-d692-4459-923b-c9b3609b5ed6

dotnwat
dotnwat previously approved these changes Mar 27, 2024
View reviewed changes
@michael-redpanda
Copy link
Contributor Author

/dt

@michael-redpanda michael-redpanda force-pushed the CORE-14-disable-tests-that-fail-in-fips branch from 2776207 to 64e04a2 Compare March 28, 2024 00:21
@michael-redpanda
Copy link
Contributor Author

Blocked on redpanda-data/ducktape#34

@michael-redpanda michael-redpanda force-pushed the CORE-14-disable-tests-that-fail-in-fips branch from 64e04a2 to 87acc73 Compare March 28, 2024 00:28
@michael-redpanda
Copy link
Contributor Author

/cdt
fips
rp_git_version=CORE-14-disable-tests-that-fail-in-fips
ducktape_deps_git_version=CORE-14-disable-tests-that-fail-in-fips
rp_version=build

@michael-redpanda
Copy link
Contributor Author

/dt

@michael-redpanda
Copy link
Contributor Author

CI issue: #14139

Known issue with Flink in FIPS CDT: https://github.com/redpanda-data/core-internal/issues/1216

@michael-redpanda
tests/dt: Update DT tag to use ok_to_fail_fips tag
ab02275 
Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda
dt/audit: Added @ok_to_fail_fips on all audit log tests
5e5c92c 
Currently, we are unable to build the OCSF server in FIPS mode,
so none of the audit log tests will pass.  Mark them as
ok_to_fail_fips

Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda
rptest: Made curl command backwards compatible
63fe4ef 
Made curl command in redpanda_installer compatible with older versions
of curl.

Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda michael-redpanda force-pushed the CORE-14-disable-tests-that-fail-in-fips branch from 87acc73 to 63fe4ef Compare March 28, 2024 14:18
@michael-redpanda
Copy link
Contributor Author

Force push 63fe4ef:

  • Fixed merge conflict in audit_log_test.py

@michael-redpanda michael-redpanda merged commit f5ad6f7 into dev Mar 28, 2024
20 of 23 checks passed
@michael-redpanda michael-redpanda deleted the CORE-14-disable-tests-that-fail-in-fips branch March 28, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphcareful graphcareful graphcareful approved these changes

@andrewhsu andrewhsu Awaiting requested review from andrewhsu

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees

@michael-redpanda michael-redpanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michael-redpanda @vbotbuildovich @dotnwat @graphcareful