Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c/frag_vector: added get_allocator() method to fragmented vector #17421

Merged

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Mar 27, 2024

Added get_allocator() method to fragmented vector to be able to move the chunked_hash_map as in its move assignment operator it queries the allocator from index underlying data structure.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Added `get_allocator()` method to fragmented vector to be able to move
the `chunked_hash_map` as in its move assignment operator it queries the
allocator from index underlying data structure.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv merged commit 4809baf into redpanda-data:dev Mar 27, 2024
19 checks passed
@mmaslankaprv mmaslankaprv deleted the make-chunked-map-movable branch March 27, 2024 13:00
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-17421-v23.3.x-89 remotes/upstream/v23.3.x
git cherry-pick -x 93b2df4a842b13faa71124358c646523b6cc9ec3

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants