Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorizer: add parens #17427

Merged

Conversation

travisdowns
Copy link
Member

To silence -Wlogical-op-parentheses warning (which oddly only occurs on remote icecc machines though it looks to me like it should always fire).

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

rockwotj
rockwotj previously approved these changes Mar 27, 2024
oleiman
oleiman previously approved these changes Mar 27, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Thanks @travisdowns!

@travisdowns
Copy link
Member Author

It is weird. It looks to me like the warning (actually error due to our use of -Werror) should always fire, but it doesn't. However, ccache and preprocessing can complicate this since the compiler tries to avoid emitting these warnings for certain header files or perhaps all header files in some cases, and ccache likes to pre-process the file in order to check for cache hits and then pass that pre-processed file directly through to the compiler to avoid having the compiler pre-process it again and in some cases this can change the warning/error suppression behavior. Admittedly hand wavy but I thought I'd just fix it versus digging deeper than that.

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/46878#018e803e-4297-407a-9723-927c99798026:

"rptest.tests.cloud_storage_scrubber_test.CloudStorageScrubberTest.test_scrubber.cloud_storage_type=CloudStorageType.S3"

To silence -Wlogical-op-parentheses warning (which oddly only occurs
on remote icecc machines though it looks to me like it should
always fire).
@travisdowns
Copy link
Member Author

Updated as this moved to the .cc from the .h.

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 31, 2024

@travisdowns travisdowns merged commit 7e4bab6 into redpanda-data:dev Apr 1, 2024
17 checks passed
@travisdowns travisdowns deleted the td-authorizer-add-parents branch April 1, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants