Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PESDLC-1036 Wait for metrics at startup of producer_swarm #17436

Merged
merged 1 commit into from
Mar 28, 2024
Merged

PESDLC-1036 Wait for metrics at startup of producer_swarm #17436

merged 1 commit into from
Mar 28, 2024

Conversation

savex
Copy link
Contributor

@savex savex commented Mar 27, 2024 •
edited 

When is_alive check is done and gives YES the merics endpoint is not ready yet
and subsequent try to get them with await_progress will result in Exception.
This adds fake metrics getter/waiter that serves as an indication that metrics
is available

Fixes: #16865

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@savex
PESDLC-1036 Wait for metrics at startup
ed7a8e1 
    When is_alive check is done and gives YES the merics endpoint is not ready yet
    and subsequent try to get them with await_progress will result in Exception.
    This adds fake metrics getter/waiter that serves as an indication that metrics
    is available
@savex savex requested a review from ballard26 March 27, 2024 16:17
@savex savex marked this pull request as ready for review March 27, 2024 16:17
@savex
Copy link
Contributor Author

savex commented Mar 27, 2024

Tested on EC2 cluster.

test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 2.082 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.555 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.977 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.426 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 1.817 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 2.203 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 1.866 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.824 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.703 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.697 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.383 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 1.989 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.820 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.963 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 4.008 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 1.465 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 3.934 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 1.752 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 4.024 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.tests.services_self_test.ProducerSwarmSelfTest.test_producer_swarm
status:     PASS
run time:   1 minute 1.981 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
============================================================================================================================================================================================================================================================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.18
session_id:       2024-03-27--008
run time:         21 minutes 35.283 seconds
tests run:        20
passed:           20
flaky:            0
failed:           0
ignored:          0
opassed:          0
ofailed:          0
============================================================================================================================================================================================================================================================================================================================

ballard26
ballard26 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ballard26 ballard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/46901#018e80e4-9dcc-437c-a147-5d13439653d4:

"rptest.tests.controller_log_limiting_test.ControllerLogLimitPartitionBalancerTests.test_partition_balancer_with_limits"

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46901#018e81e8-9f4d-4c91-9247-ee9b569bed76

@savex savex merged commit 7c86899 into dev Mar 28, 2024
18 checks passed
@savex savex deleted the PESDLC-1036-fix-swarm-metrics-start branch March 28, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ballard26 ballard26 ballard26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (failed to start client-swarm) in ProducerSwarmSelfTest.test_producer_swarm
3 participants
@savex @vbotbuildovich @ballard26