Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PESDLC-1021 Update cloud cleanup with options #17444

Merged
merged 1 commit into from
Mar 28, 2024
Merged

PESDLC-1021 Update cloud cleanup with options #17444

merged 1 commit into from
Mar 28, 2024

Conversation

savex
Copy link
Contributor

@savex savex commented Mar 27, 2024 •
edited

Buckets and NATs need cleaning after actual test runs.
This commit adds option to call specific cleanup.

Before cleaning any NAT, it is checked that it is 36h old and is present in records of current Cloud API (preprod/integration). This is done in order to avoid cleaning wrong NATs.

Buckets will be cleaned after 36h and all of mentioned names hold no critical information to be preserved, only test data

        cleaner.clean_buckets(mask="panda-bucket-")
        cleaner.clean_buckets(mask="redpanda-cloud-storage-")
        cleaner.clean_buckets(mask="redpanda-network-logs-")

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@savex savex self-assigned this Mar 27, 2024
@savex savex requested review from ivotron and rpdevmp March 27, 2024 21:09
@savex savex marked this pull request as ready for review March 27, 2024 21:09
@savex
Copy link
Contributor Author

savex commented Mar 27, 2024

Related vtools PR to be merged after this one is https://github.com/redpanda-data/vtools/pull/2601

rpdevmp
rpdevmp previously approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/rp_cloud_cleanup.py Show resolved Hide resolved
@savex
PESDLC-1021 Update cloud cleanup with options
76f217f 
    Buckets and NATs need cleaning after actual test runs.
    This commit adds option to call specific cleanup.
@savex savex force-pushed the PESDLC-1021-clean-buckets-script branch from fff8101 to 76f217f Compare March 27, 2024 21:41
rpdevmp
rpdevmp approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savex savex merged commit 6464f84 into dev Mar 28, 2024
16 checks passed
@savex savex deleted the PESDLC-1021-clean-buckets-script branch March 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpdevmp rpdevmp rpdevmp approved these changes

@ivotron ivotron Awaiting requested review from ivotron

Assignees

@savex savex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@savex @rpdevmp