Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report cloud log size in redpanda_cloud_storage_cloud_log_size probe #17445

Merged
merged 2 commits into from
Mar 28, 2024
Merged

report cloud log size in redpanda_cloud_storage_cloud_log_size probe #17445

merged 2 commits into from
Mar 28, 2024

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Mar 27, 2024 •
edited

adds new probe repdanda_cloud_storage_cloud_log_size to report the total size of the user-visible log.

uses information already tracked in the partition manifest

Fixes https://github.com/redpanda-data/core-internal/issues/1214

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Improvement

  • new metric redpanda_cloud_storage_cloud_log_size reports size in bytes of the log in cloud storage

@andijcr
archival/probe: redpanda_cloud_storage_cloud_log_size
a6d9cbb 
report the size in bytes of the user-visible log saved in cloud storage
@andijcr
archival/ntp_archiver_service: probe->cloud_log_size()
87d6a2a 
update redpanda_cloud_storage_cloud_log_size in update_probe()
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46936#018e8245-aec7-4f9e-8215-bd94ea13284c

@andijcr
Copy link
Contributor Author

andijcr commented Mar 28, 2024

issue is known #14139

@andijcr andijcr requested a review from dotnwat March 28, 2024 16:06
@dotnwat dotnwat merged commit fa61ab9 into redpanda-data:dev Mar 28, 2024
16 of 19 checks passed
@andijcr andijcr deleted the feat/vectorized_ntp_archiver_partition_size_bytes branch March 28, 2024 18:24
andrwng
andrwng reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrwng andrwng andrwng left review comments

@dotnwat dotnwat dotnwat approved these changes

Assignees
No one assigned
Labels
area/redpanda doc-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andijcr @vbotbuildovich @dotnwat @andrwng