RBAC: remove update role and friends #17446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgellert
approved these changes
Mar 28, 2024
BenPope
reviewed
Mar 28, 2024
Good spot, thanks. I intended the opposite order and must have cancelled my rebase... |
Includes cluster command, admin routes, wrappers and supporting code for those.
oleiman
force-pushed
the
rbac/remove-rename
branch
from
f697faa
to
78ade10
Compare
|
empty force push to swap first two commits |
michael-redpanda
approved these changes
Mar 28, 2024
dotnwat
approved these changes
Mar 28, 2024
|
CI Failures:
|
|
/ci-repeat 1 |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47042#018e8784-ae54-45b3-8315-30c105a868d9 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47042#018e8784-ae51-46ff-ac25-e353f930c0a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion with product, UI, and console teams, we determined that, absent the ability to redirect existing ACLs to the new role, the act of renaming a Role is not particularly useful. So we're removing it.
Closes https://github.com/redpanda-data/core-internal/issues/1204
Backports Required
Release Notes