io: clang tidy fixes #17450
Merged
io: clang tidy fixes #17450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/home/nwatkins/src/redpanda-storage-v2/src/v/io/pager.cc:184:17: note: Calling 'operator co_await<void>'
co_await waiter.ready.get_future();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/src/redpanda-storage-v2/build/release-ci/_deps/seastar-src/include/seastar/core/coroutine.hh:217:5:
note: Address of stack memory associated with local variable 'f' is still referred to by the stack variable 'waiter' upon returning to the caller. This will be a dangling reference
return internal::awaiter<true, T...>(std::move(f));
^
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
rockwotj
approved these changes
Mar 28, 2024
ballard26
reviewed
Mar 28, 2024
| @@ -181,7 +181,8 @@ pager::get_page(uint64_t offset) noexcept { | |||
| if (page->test_flag(page::flags::faulting)) { | |||
| page::waiter waiter; | |||
| page->add_waiter(waiter); | |||
| co_await waiter.ready.get_future(); | |||
There was a problem hiding this comment.
Can't this be one line. I.e,
co_await std::move(waiter.ready.get_future());
There was a problem hiding this comment.
maybe. i didn't try this one because the temporary should bind to the same thing that the rvalue of std::move would produce and figured clang-tidy would still have a problem with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang tidy fixes
Backports Required
Release Notes