kafka: fix config source for default cleanup.policy config #17456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgellert
requested review from
a team,
michael-redpanda,
ztlpn and
graphcareful
and removed request for
a team
pgellert
force-pushed
the
default-config-cleanup-policy
branch
from
33b34fd
to
98876be
Compare
Currently Redpanda returns source=1 (topic-specific overwrite) for the cleanup.policy config. This is different to Apache Kafka, which returns source=5 (default config), even though the config value they return (delete) is the same, so I believe this behaviour is a bug and this commit fixes it by using the hide_default_override helper field.
pgellert
force-pushed
the
default-config-cleanup-policy
branch
from
98876be
to
78fcff7
Compare
pgellert
commented
Mar 28, 2024
Comment on lines
+140
to
+149
| # New brokers may not report the version yet, so gather the cluster version | ||
| # based on multiple brokers' reported version | ||
| versions = list( | ||
| set(broker['version'] for broker in brokers_resp | ||
| if 'version' in broker)) | ||
| assert len(versions) == 1, f"Unexpected versions: {versions}" | ||
| version_line = versions[0] | ||
|
|
||
| self.version = ver_triple(version_line) | ||
|
|
There was a problem hiding this comment.
Force-pushed to make the version uniformity check here more lenient by allowing missing versions from some nodes. This is to make the test_join_restart_catch_up test less flaky.
graphcareful
approved these changes
Mar 29, 2024
michael-redpanda
approved these changes
Apr 1, 2024
|
Kicking off a rebuild of CI as something in the infrastructure got messed up |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47172#018e9b9f-9f5e-41df-8f46-dfadf2feaca8 |
|
Can we backport this PR at least to v23.3.x? We would like to have this in the latest versions for our Terraform Provider. 😄 |
|
/backport v23.3.x |
This was referenced Apr 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the reported config source of
cleanup.policy. If I create a topic without a cleanup policy, the default cleanup policy is as configured on the broker (initially, cleanup.policy=delete). Describing a topic's configs shows:when it should show
Fixes #2225
Backports Required
Release Notes
Bug Fixes