PESDLC-1021 Use bucket policy for cleanup by default #17465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhsu
previously approved these changes
Mar 28, 2024
ivotron
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables policy based cleanup by default for tests that uses SISettings class. Most of the tests creates a lot of data and it takes an effort to clean buckets one key at a time. Policy will do it faster.
For those tests that are not using SISettings - we have rp_cloud_cleanup.py running at CDT-Cloud jobs that will apply similar policy to all of the buckets.
And as a third line - the scheduled job to clean resources on either AWS or GCP
Backports Required
Release Notes