security: Various minor cleanups #17467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
And pass around members_store accessor as a noncopyable_function Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
To return the number of roles in the store. Also updates metrics_reporter to use this rather than a full on range query, which would return a materialized container rather than a view. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
oleiman
force-pushed
the
security/cleanups
branch
from
84fc3c0
to
804134f
Compare
BenPope
approved these changes
Mar 28, 2024
BenPope
reviewed
Mar 28, 2024
| @@ -58,28 +58,7 @@ struct auth_result { | |||
| // If found, the role that was matched to provide authZ decision | |||
| std::optional<security::role_name> role; | |||
|
|
|||
| friend std::ostream& operator<<(std::ostream& os, const auth_result& a) { | |||
There was a problem hiding this comment.
nitpick: Now you can move <fmt/core.h> to the .cc, but you'll have to add <iosfwd>
|
/ci-repeat 1 |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47063#018e8959-0c2f-464b-a070-589b74f8ef81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PR comments from #17152, and a small related change to metrics_reporter
Backports Required
Release Notes