rptest: Fix throttling test #17474
Merged
rptest: Fix throttling test #17474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid restarting redpanda durint the e2e test. Restart resets the metrics and the second run of the consumer after restart is not guaranteed to hit throttling because the data is cached.
6 tasks
andrwng
approved these changes
Mar 28, 2024
Comment on lines
-1391
to
-1400
| self.logger.info("Stop nodes") | ||
| for node in self.redpanda.nodes: | ||
| self.redpanda.stop_node(node, timeout=120) | ||
|
|
||
| self.logger.info("Start nodes") | ||
| for node in self.redpanda.nodes: | ||
| self.redpanda.start_node(node, timeout=120) | ||
|
|
||
| self.logger.info("Restart consumer") | ||
| self.consume() |
There was a problem hiding this comment.
Makes sense. This makes me wonder why we restarted in the first place 🤔
There was a problem hiding this comment.
yeh not sure. probably copy/paste
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47041#018e878b-2c32-4b52-b4d8-a04706aaf452 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47054#018e8866-b9d0-46f6-86ad-a3943d79ba15 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47054#018e8866-b9d0-472b-acdb-f03c3f1a710a |
|
/ci-repeat 2 |
|
/backport v23.3.x |
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid restarting redpanda durint the e2e test. Restart resets the metrics and the second run of the consumer after restart is not guaranteed to hit throttling because the data is cached.
Fixes: #14139
Backports Required
Release Notes