Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics_reporter to show the number of rbac roles #17501

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Mar 29, 2024

Update metrics_reporter to show the number of rbac roles rather than a bool for whether there are any roles present.

Closes https://github.com/redpanda-data/core-internal/issues/1213

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Report the number of roles in the system, rather than just whether there are
_any_ roles in the system, to provide a more detailed signal with respect to
adoption.

Especially relevant since we'll be creating a default "Users" role on initial
upgrade to an RBAC-supporting version of redpanda.

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenPope BenPope requested a review from deniscoady April 2, 2024 12:03
@oleiman oleiman merged commit 980d37e into redpanda-data:dev Apr 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants