Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PESDLC-1021 Add optional 8h delay to bucket cleaning #17525

Merged
merged 1 commit into from
Apr 1, 2024
Merged

PESDLC-1021 Add optional 8h delay to bucket cleaning #17525

merged 1 commit into from
Apr 1, 2024

Conversation

savex
Copy link
Contributor

@savex savex commented Apr 1, 2024

Main cleanup script can’t handle very big buckets and goes deep into recursive deletions. Example: https://buildkite.com/redpanda/vtools-cleanups

Actions:

  • switch to per-bucket deletions using s3clean.sh
  • add option to use 8h delay to rp_cloud_cleanup.py

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@savex savex requested a review from gousteris April 1, 2024 13:32
@savex savex marked this pull request as ready for review April 1, 2024 13:32
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47158#018e9a15-5540-43fd-b269-605139381069

@savex savex requested a review from rpdevmp April 1, 2024 16:18
rpdevmp
rpdevmp approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should help with cleanup

@savex savex merged commit c15285d into dev Apr 1, 2024
17 checks passed
@savex savex deleted the PESDLC-1021-add-8h-bucket-cleanup branch April 1, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpdevmp rpdevmp rpdevmp approved these changes

@gousteris gousteris Awaiting requested review from gousteris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@savex @vbotbuildovich @rpdevmp