net/tls_probe: Introduce "trust_file_crc32c" metric #17539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute the crc32c checksum on the complete binary contents of the trust file on certificate creation and reload. Export this value on the metric iff a trust file is present AND certs are otherwise valid. Otherwise export 0. This will be particularly useful for cloud clients who want to verify the contents of the trust store but don't have direct access to the filesystem of the host.
|
Build will stay broken until https://github.com/redpanda-data/vtools/pull/2616 lands (supporting seastar change), but I've built the vtools PR against this stack and everything seems to be in order. |
|
Is there a documentation update that will be requested from this pr? |
good point. threw the |
pgellert
approved these changes
Apr 3, 2024
|
/backport v23.3.x |
|
@oleiman best way to move things forward is to create a doc issue at https://github.com/redpanda-data/documentation-private I've created one for this task, but need some details |
|
Ah, thank you @Deflaimun 👀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute the crc32c checksum on the complete binary contents of the
trust file on certificate creation and reload. Export this value on
the metric iff a trust file is present AND certs are otherwise valid.
Otherwise export 0.
This will be particularly useful for cloud clients who want to verify
the contents of the trust store but don't have direct access to the
filesystem of the host.
Closes https://github.com/redpanda-data/core-internal/issues/1184
Backports Required
Release Notes
Features