Removed adl support for cluster rpc types
#17551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
force-pushed
the
cluster-types-adl-cleanup
branch
from
556d5ec
to
fe33745
Compare
Since we are not longer need to support ADL serialization of types being used in RPC, we can remove all `adl` support for cluster types which are only exchanged in rpc calls. Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
cluster-types-adl-cleanup
branch
from
fe33745
to
3ed650d
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47224#018ea067-c638-47cf-a996-5884f2495e9a |
ztlpn
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Hmm aren't we still using adl for topic configurations stored in old controller commands (and therefore this test is still marginally useful)?
There was a problem hiding this comment.
we do, but we have snapshots now, so it is almost impossible to hit this command after the update
There was a problem hiding this comment.
ztlpn
approved these changes
Apr 3, 2024
ztlpn
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are not longer need to support ADL serialization of types being
used in RPC, we can remove all
adlsupport for cluster types which areonly exchanged in RPC calls.
Backports Required
Release Notes