remote: fix exception checking in delete_objects_sequentially #17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Catching the exception with `const std::exception&` as the type forces the compiler to understand the error's type as `std::exception`, and trips up our shutdown-error-checking[1]. This change updates the code to pass the `std::current_exception()` `exception_ptr` directly to `is_shutdown_exception()`. This previously showed up as an error log: ``` cloud_storage - [fiber28~216|0|29845ms] - remote.cc:1293 - Failed to delete keys: Sleep is aborted ``` Fixes redpanda-data#17506 [1] https://godbolt.org/z/xqeabz35r
andrwng
force-pushed
the
remote-delete-shutdown-errors
branch
from
f2a143b
to
7c09f37
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47249#018ea14d-02d8-4e53-a070-a0cf1a83a8cd |
Lazin
approved these changes
Apr 4, 2024
| }); | ||
| std::vector<upload_result> results; | ||
| results.reserve(key_nodes.size()); | ||
| auto fut = co_await ss::coroutine::as_future(ss::max_concurrent_for_each( |
There was a problem hiding this comment.
didn't know about coroutine::as_future, this is really nice
dotnwat
reviewed
Apr 6, 2024
| results.push_back(result); | ||
| }); | ||
| }) | ||
| .handle_exception_type([ctxlog](const std::exception& ex) { |
There was a problem hiding this comment.
+1 to switching to coroutine. Just so I understand, this fix could also have been to change .handle_exception_type([ctxlog](const std::exception& ex) to .handle_exception([ctxlog](std::exception_ptr eptr)?
There was a problem hiding this comment.
Ha 🤦, yea I think so
This was referenced Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching the exception with
const std::exception&as the type forces the compiler to understand the error's type asstd::exception, and trips up our shutdown-error-checking[1].This change updates the code to pass the
std::current_exception()exception_ptrdirectly tois_shutdown_exception().This previously showed up as an error log:
Fixes #17506
[1] https://godbolt.org/z/xqeabz35r
Backports Required
Release Notes