[v23.3.x] Improved validation of Fetch requests when reading from follower #17574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 351f00a)
When truncation happens all the offsets should be updated before it finishes as the truncated data should not be accessed during and immediately after truncation. Updating offsets before truncation guarantees the state is up to data right after the truncation finishes. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit a1097d4)
Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 69753bb)
When reading from the follower the offset information may not be up to date. In Redpanda we implemented the behavior that is described in `KIP-392`. The described mechanism assumes that consumer will reconcile with the leader after they receive the offset out of range error from the follower. This is not implemented by the clients hence returning out of range error resulted in offset reset. With the fix in this commit we will never return the out of range error from a node not being a leader. This way consumers will only use leader to validate its offset and we will avoid spurious resets. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 0c6354c)
mmaslankaprv
force-pushed
the
vbotbuildovich/backport-17498-v23.3.x-251
branch
from
cf2df60
to
d140352
Compare
|
ci failure: #17222 |
bharathv
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17498