Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: check schema registry ABI #17591

Merged
merged 3 commits into from
Apr 5, 2024
Merged

wasm: check schema registry ABI #17591

merged 3 commits into from
Apr 5, 2024

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Apr 3, 2024 •
edited

Introduce a versioning schema to schema registry in data transforms, a followup PR will add these methods to the SDKs.

Fixes: CORE-2007

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • Add error messages when an unsupported Schema Registry client is used in Data Transforms

@github-actions github-actions bot added area/redpanda area/wasm WASM Data Transforms labels Apr 3, 2024
@rockwotj rockwotj self-assigned this Apr 3, 2024
@rockwotj rockwotj mentioned this pull request Apr 3, 2024
Merged
6 tasks
@rockwotj rockwotj requested a review from oleiman April 3, 2024 19:38
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 3, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/47330#018ea59e-8469-48ac-8ea6-9ed5146fbe42:

"rptest.tests.data_transforms_test.DataTransformsTest.test_validation"

new failures in https://buildkite.com/redpanda/redpanda/builds/47330#018ea5a6-cffe-4a4d-a762-237f65dda6df:

"rptest.tests.data_transforms_test.DataTransformsTest.test_validation"

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47330#018ea5a6-cffb-42cb-a1c2-f3ceb895dd0e

@rockwotj
Copy link
Contributor Author

rockwotj commented Apr 4, 2024

CI Failure: storage_e2e_single_thread_rpunit

@rockwotj
wasm: suppress clang-tidy warning
a06dbed 
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
wasm/sr: add ABI versioning
eb40013 
In order to give more helpful error messages when folks try to deploy an
unsupported schema registry version that we don't support, ensure that
we have an ABI versioning function and check it at deploy time.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
admin/server: error messages for invalid wasm sr
38c3c08 
In the case a user tries to deploy a wasm function that we don't
support, report a clear error message as to what could be wrong.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
Copy link
Contributor Author

rockwotj commented Apr 4, 2024

Force push: resolve conflicts with dev

oleiman
oleiman approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand how the ABI check correlates to a schema registry client version, but the PR itself lgtm

@rockwotj
Copy link
Contributor Author

rockwotj commented Apr 4, 2024

This PR helps the user if they try and deploy a data transform with a version more recent than the broker supports, the broker will now return an error, before it would fail at compile time

@oleiman
Copy link
Member

oleiman commented Apr 4, 2024

This PR helps the user if they try and deploy a data transform with a version more recent than the broker supports, the broker will now return an error, before it would fail at compile time

Yeah I get that, just wondering about the mechanism. The follow-up PR makes it more clear.

@rockwotj rockwotj merged commit 94df335 into redpanda-data:dev Apr 5, 2024
18 checks passed
@rockwotj rockwotj deleted the wasm-sr branch April 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

Assignees

@rockwotj rockwotj

Labels
area/redpanda area/wasm WASM Data Transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rockwotj @vbotbuildovich @oleiman