Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: generate script with sha256sum instead of md5sum #17595

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Apr 3, 2024

issue https://redpandadata.atlassian.net/browse/PESDLC-1040

follow-on to PR #17568, this PR changes the way tune scripts are generated so that sha256sum is used instead of md5sum.

rpk redpanda tune disk_irq --output-script=tune_disk_irq.sh
bash$ head tune_disk_irq.sh
#!/bin/bash

# Redpanda Tuning Script
# ----------------------------------
# This file was autogenerated by RPK

file_hash=$(sha256sum /etc/default/irqbalance | cut -c -32)
cp /etc/default/irqbalance /etc/default/irqbalance.vectorized.${file_hash}.bk
cat << EOF > /etc/default/irqbalance
  # irqbalance is a daemon process that distributes interrupts across

this PR does not change dependency requirements of the user because like md5sum, sha256sum is also provided by coreutils package.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • rpk: tune script uses sha256sum instead of md5sum

@andrewhsu andrewhsu requested a review from a team as a code owner April 3, 2024 20:26
@andrewhsu andrewhsu requested review from savex and removed request for a team April 3, 2024 20:26
@andrewhsu andrewhsu merged commit 20e4cd8 into redpanda-data:dev Apr 5, 2024
22 checks passed
@andrewhsu andrewhsu deleted the PESDLC-1040-generate-script branch April 5, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants