CORE-2055: net: allow transport logger to be customized #17596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling this as it was enabled without testing in the open-source build where the macro is active. There are a lot of warnings. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Before this change anything the net::transport logger would log would show up as the RPC logger rather than specializations like http,kafka. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
commented
Apr 3, 2024
| @@ -13,6 +13,7 @@ | |||
| #include "base/seastarx.h" | |||
| #include "base/vassert.h" | |||
| #include "config/property.h" | |||
| #include "rpc/logger.h" | |||
There was a problem hiding this comment.
this is a separate PR the conn_quota is separate from the net::transport which is handled in this PR
andrwng
approved these changes
Apr 3, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47339#018ea60d-82a1-4e68-a12b-a64264dfb73d |
dotnwat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net: allow transport logger to be customized
Backports Required
Release Notes