Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PESDLC-1063 Refactor test_consume_miss_cache #17615

Merged
merged 2 commits into from
Apr 9, 2024
Merged

PESDLC-1063 Refactor test_consume_miss_cache #17615

merged 2 commits into from
Apr 9, 2024

Conversation

savex
Copy link
Contributor

@savex savex commented Apr 3, 2024

With recent changes in RedpandaServiceCloud class, ensure that mentioned test is working and make necessary updates

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@savex
PESDLC-1063 Support pods instead of nodes
506d1a7 
   Recent changes in RedpandaServiceCloud offers use of bare argument
   for existing metrics_check class. Only update is for handling no
       metrics/samples situation
@savex savex force-pushed the PESDLC-1063-htt-test-consume-miss-cache branch from 34a417e to 506d1a7 Compare April 3, 2024 22:54
@savex
Copy link
Contributor Author

savex commented Apr 3, 2024

EC2 run results:

test_id:    rptest.redpanda_cloud_tests.high_throughput_test.HighThroughputTest.test_consume_miss_cache
status:     PASS
run time:   55 minutes 14.803 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.redpanda_cloud_tests.cloud_self_test.SelfRedpandaCloudTest.test_healthy
status:     PASS
run time:   45.499 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
============================================================================================================================================================================================================================================================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.18
session_id:       2024-04-03--002
run time:         56 minutes 3.416 seconds
tests run:        2
passed:           2
flaky:            0
failed:           0
ignored:          0
opassed:          0
ofailed:          0
opassedfips:      0
ofailedfips:      0
============================================================================================================================================================================================================================================================================================================================

@savex savex marked this pull request as ready for review April 3, 2024 23:06
@savex
Copy link
Contributor Author

savex commented Apr 3, 2024

/ci-repeat 1

rpdevmp
rpdevmp previously approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dotnwat
dotnwat reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when commenting out lines of code, please either (1) add a comment or (2) update the commit message for future readers of the code who will wonder why this thing is commented out and if it were temporary etc...

tests/rptest/redpanda_cloud_tests/high_throughput_test.py Outdated Show resolved Hide resolved
tests/rptest/redpanda_cloud_tests/high_throughput_test.py Outdated Show resolved Hide resolved
@savex
Copy link
Contributor Author

savex commented Apr 5, 2024

Yes, that's what I usually do. Here, I just forgot to remove them after debugging.

@savex savex requested review from rpdevmp and dotnwat April 5, 2024 23:04
dotnwat
dotnwat reviewed Apr 6, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @savex

rpdevmp
rpdevmp approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savex savex merged commit 4c47fe9 into dev Apr 9, 2024
16 checks passed
@savex savex deleted the PESDLC-1063-htt-test-consume-miss-cache branch April 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat left review comments

@rpdevmp rpdevmp rpdevmp approved these changes

@travisdowns travisdowns Awaiting requested review from travisdowns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@savex @dotnwat @rpdevmp