cluster: create default "Users" role when RBAC is activated #17624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47376#018ea896-eb55-461e-99e5-db751dd58679 |
BenPope
reviewed
Apr 4, 2024
pgellert
force-pushed
the
rbac/default-role-on-upgrade
branch
from
908f0d0
to
7b66833
Compare
|
Force-pushed to address all of the comments above |
oleiman
reviewed
Apr 4, 2024
We don't want to bother customers with a license nag for the role we auto-create for the users.
pgellert
force-pushed
the
rbac/default-role-on-upgrade
branch
from
7b66833
to
687bc3f
Compare
|
Force-pushed to prevent allocating the range query result. |
oleiman
approved these changes
Apr 4, 2024
| return "role_base_access_control"; | ||
| return "role_based_access_control"; |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a one-time convenience functionality. On the first upgrade to an RBAC-supporting build, this creates a "Users" role that contains all the existing SASL/SCRAM users to help customers get started with RBAC.
It uses the already implemented feature migrator to create a role when the feature first becomes active.
Finally, it implements a suppression to the license nag to not show the license nag for this auto-generated role.
Closes https://github.com/redpanda-data/core-internal/issues/1205
Backports Required
Release Notes