transform: convert to new-style module #17626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was implicit via fixture.h includes, now it's explicit. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Instead of including a application header in cluster (creating dep cycles), inject the application start time into members_manager by wiring it through. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
As an implmentation detail so that transform/logging/event.h can be an private includes and not part of the public api for transform/logging Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Currently this is being included in app and transform/rpc but is compiled in transform (which includes transform/rpc), move it into it's own module so that it's standalone. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Generated code isn't present in the filesystem so we can't do these checks in the same way, just add an allowlist to ignore these files for now. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
|
/ci-repeat |
dotnwat
approved these changes
Apr 4, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47387#018ea965-032d-4276-a87c-2aeb0b2a890a ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47387#018ea965-032f-46b3-a145-3a015041ad78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert transform and wasm subsystems into new style include modules.
This also caught an import cycle between cluster <-> redpanda, which is now removed.
Fixes: CORE-2067
Fixes: CORE-2068
Backports Required
Release Notes