Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: use registry version of common protos #17628

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

bojand
Copy link
Member

@bojand bojand commented Apr 4, 2024

this commit replaces the internal common proto
definitions with a go module that comes from
buf schema registry, at
buf.build/gen/go/redpandadata/common/protocolbuffers/go

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • rpk: use go module version of common proto definitions.

this commit replaces the internal common proto
definitions with a go module that comes from
buf schema registry, at
buf.build/gen/go/redpandadata/common/protocolbuffers/go

rpk: use buf.build go modules for all proto dependencies
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@bojand bojand merged commit 153baf0 into redpanda-data:dev Apr 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants