rpk: move acl / acl user to /security #17664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This movement is a soft deprecation to the previous command. The old command will work as intended but print a WARN message (only visible with -v) showing that the command is deprecated.
This is done in _some_ commands, not all. We want to make sure that both (old and new) still work.
gene-redpanda
previously approved these changes
Apr 4, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47417#018eab71-0ed4-4e35-9b7f-bacc4b19d269 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47423#018eabfc-8efa-4d5d-90e4-8a742eb89071 |
gene-redpanda
approved these changes
Apr 5, 2024
bojand
reviewed
Apr 5, 2024
| When you create a role, you must bind or associate ACLs to it before it can be | ||
| used. You can create / delete / list ACLs for that role with "<name>" in the | ||
| --allow-role and --deny-role flags. Note that the wildcard role name '*' is not | ||
| permitted here. For example 'rpk acl create --allow-role '*' ...' will produce |
There was a problem hiding this comment.
I think this should say 'rpk security acl create --allow-role '*' ...' ?
bojand
reviewed
Apr 5, 2024
|
|
||
| Check --help-operations to see which operations are required for which | ||
| requests. In flag form to set up a general producing/consuming client, you can | ||
| invoke 'rpk acl create' three times with the following (including your |
There was a problem hiding this comment.
similarly here 'rpk security acl create' ?
|
Because we want to tag rc-1, I'll go ahead with the merge and the minor nits above could come in a follow-up PR. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This movement is a soft deprecation to the previous command. The old command will work as intended
but print a WARN message (only visible with -v)
showing that the command is deprecated.
Backports Required
Release Notes
Improvements
rpk aclhas been moved torpk security acl. Old command is soft deprecated.rpk acl userhas been moved torpk security security. Old command is soft deprecated.