Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh: Improve workflow script #17672

Merged
merged 1 commit into from
Apr 5, 2024
Merged

gh: Improve workflow script #17672

merged 1 commit into from
Apr 5, 2024

Conversation

michael-redpanda
Copy link
Contributor

  • Jira doesn't permit labels with spaces, so replace spaces with '-' for GH labels
  • Do not automatically create issues if the event is just a labeling or unlabeling event or if the issue is already closed and being edited

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@michael-redpanda michael-redpanda self-assigned this Apr 5, 2024
@michael-redpanda michael-redpanda marked this pull request as ready for review April 5, 2024 12:47
@michael-redpanda michael-redpanda requested a review from a team as a code owner April 5, 2024 12:47
@michael-redpanda michael-redpanda requested review from gousteris and removed request for a team April 5, 2024 12:47
rockwotj
rockwotj reviewed Apr 5, 2024
View reviewed changes
.github/workflows/scripts/jira_helper.py Outdated Show resolved Hide resolved
.github/workflows/scripts/jira_helper.py Outdated Show resolved Hide resolved
.github/workflows/scripts/jira_helper.py Outdated Show resolved Hide resolved
@michael-redpanda
gh: Improve workflow script
f2905ff 
- Jira doesn't permit labels with spaces, so replace spaces with
  '-' for GH labels
- Do not automatically create issues if the event is just a labeling
  or unlabeling event or if the issue is already closed and being
  edited
- If the labels `kind/bug` or `ci-failure` is present, then create
  a Jira bug

Signed-off-by: Michael Boquard <michael@redpanda.com>
rockwotj
rockwotj approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up, I think this is way easier to follow

@michael-redpanda michael-redpanda merged commit df33718 into dev Apr 5, 2024
11 checks passed
@michael-redpanda michael-redpanda deleted the improve-issue-labeling branch April 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwotj rockwotj rockwotj approved these changes

@gousteris gousteris Awaiting requested review from gousteris gousteris is a code owner automatically assigned from redpanda-data/devprod

@dotnwat dotnwat Awaiting requested review from dotnwat

@travisdowns travisdowns Awaiting requested review from travisdowns

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

Assignees

@michael-redpanda michael-redpanda

Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michael-redpanda @rockwotj